fix: add missing exports for subpath module #2268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subpath exports should be defined via package.json exports field for ESM
|
@tordans Yes, it works well with bundlers like webpack. But as I mentioned in the description the package is still not ESM compliant, therefore it's not compatible with strict environments like node.js. The next step should be ESM compliant package. |
Pessimistress
approved these changes
Sep 5, 2023
|
@khmm12 do you have experience with how to best do this? I am just reading about https://deno.com/blog/publish-esm-cjs-module-dnt which sounds nice but is based on Deno as an entry point… |
|
Closing in favor of #2281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subpath exports should be defined via package.json exports field for ESM.
It's still not ESM compliant, because inside CJS packages ESM modules should have extension
.mjsand all their imports should be fully specifiedimport './events.mjs', notimport './events'.